justinmclean opened a new pull request, #216:
URL: https://github.com/apache/airflow-steward/pull/216
## What
Adds a new `validate_gh_list_limit` check that flags `gh issue list` and
`gh pr list` calls in fenced code blocks that have no `--limit` argument.
## Why
`gh issue list` and `gh pr list` default to 30 results. On a large repo
like apache/airflow with thousands of open issues, this silently truncates
— any downstream logic (counting, filtering, looping) operates on an
incomplete set with no error or warning. Adding `--limit` makes the intent
explicit and prevents hard-to-spot data loss.
## Changes
**`tools/skill-validator`**
- New `GH_LIST_CATEGORY` constant (`gh_list_no_limit`), added to
`SOFT_CATEGORIES`
- New `_join_continuations` helper: joins shell line-continuations (`\` +
newline)
before checking, so `--limit` on a continuation line is correctly
recognised
- New `validate_gh_list_limit` — scans fenced blocks only; prose and inline
backtick mentions are not flagged
- Wired into `run_validation` for all skill `.md` files
- `"gh-list-no-limit"` added to `_SOFT_RULE_PREFIXES`
- 9 new tests in `TestGhListLimit`
## Real gaps found (3)
- `pr-management-triage/actions.md:517`
- `pr-management-code-review/selectors.md:119`
- `security-issue-invalidate/SKILL.md:246`
The `selectors.md:484` call (`gh pr list \ ... --limit 100` across
continuation
lines) is correctly silent — the multiline join handles it.
## Notes
All violations are SOFT — advisory warnings that do not fail CI unless
`--strict` is passed. Even so, the 3 flagged files have been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
