potiuk opened a new pull request, #226: URL: https://github.com/apache/airflow-steward/pull/226
## Summary Two related improvements found while running `pr-management-stats` on a large queue (apache/airflow, 477 open PRs): 1. **Rows 19, 20, and F4 — exclude non-collaborator unresolved threads** from the mark-ready / already-ready predicates. Contributor-author threads (drive-by reviewers, copilot bot, etc.) no longer block mark-ready or trip the regression check on already-ready PRs. Mirrors the collaborator-author qualifier that `unresolved_threads_only` (rows 14c/15) already uses. 2. **Author-primary templates** (`request-author-confirmation`, `reviewer-ping` author-primary, `review-nudge` author-primary) — new `<reviewer_logins>` placeholder renders reviewers as backtick-quoted code (no `@`-ping), so the bot's message doesn't notify the reviewer when the next action is on the author. Templates additionally instruct the author to mark threads resolved and `@`-mention the reviewer themselves once ready — the ping comes from the author (who has done the work) rather than from the bot (which only saw engagement). Reviewer-re-review variants and `mark-ready-with-ping` keep using `<reviewers>` (the `@`-form) because in those flows the reviewer IS the next-action recipient. ## Motivation **Row 20:** running `pr-management-stats` on apache/airflow, 6 PRs with SUCCESS rollup, no conflicts, 0 collab unresolved threads, but 1-4 contributor-author threads were stuck in unclassified limbo — no row matched them. After this change they cleanly land in `passing → mark-ready`. **Reviewer mentions:** the `<reviewers>` `@`-form was producing notifications for reviewers in templates whose next action was on the author. apache/airflow adopters had been working around this in a local override; this PR upstreams the contract. ## Backward compatibility - Behavior change in rows 19/20/F4 is a **strict relaxation** — PRs that were previously blocked from mark-ready by contributor-author threads will now reach mark-ready. PRs that previously could be marked ready remain markable. - New `<reviewer_logins>` placeholder is additive — adopters that don't update their `<project-config>/pr-management-triage-comment-templates.md` continue to use the literal `<reviewers>` rendering. The framework's reference templates use the new placeholder; downstream override adoption can happen on each adopter's schedule. ## Files - `.claude/skills/pr-management-triage/classify-and-act.md` — row 19, row 20, F4 wording (3 lines + cross-reference notes) - `.claude/skills/pr-management-triage/comment-templates.md` — new `Reviewer-mention policy` section, new `<reviewer_logins>` placeholder, 3 author-primary template bodies updated, prose around `<reviewers>` placeholder reframed ## Test plan - [x] Override applied at apache/airflow for ~24h covering 30+ triage actions; behaviour matches the spec. - [x] No new @-mentions of reviewers in author-primary bodies (manual diff verification). - [x] `<reviewer_logins>` rendering matches: comma-space separator, backtick wrapping, no @. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
