kir-rin commented on code in PR #67325: URL: https://github.com/apache/airflow/pull/67325#discussion_r3288087609
########## airflow-core/src/airflow/utils/file.py: ########## @@ -29,6 +29,7 @@ from typing import overload from airflow.configuration import conf +from airflow.serialization.definitions.notset import NOTSET, ArgNotSet, is_arg_set Review Comment: **[NIT]**: `NOTSET` being in `serialization.definitions` feels a bit misplaced. It's a general sentinel pattern used across multiple modules. Since NOTSET is the only place that defines this sentinel and is imported from various modules, moving it to a more general location (e.g., `shared/` or `airflow/utils/`) could help prevent subtle bugs like the default argument evaluation issue fixed in this PR and make the dependency structure more intuitive. <img width="550" height="308" alt="image" src="https://github.com/user-attachments/assets/21d39f96-f6f2-49e4-94a2-4526e1af25fd"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
