kir-rin commented on code in PR #67325:
URL: https://github.com/apache/airflow/pull/67325#discussion_r3288087609


##########
airflow-core/src/airflow/utils/file.py:
##########
@@ -29,6 +29,7 @@
 from typing import overload
 
 from airflow.configuration import conf
+from airflow.serialization.definitions.notset import NOTSET, ArgNotSet, 
is_arg_set

Review Comment:
   **[NIT]** NOTSET in `serialization.definitions` feels misplaced—it's a 
general sentinel used across modules unrelated to serialization. Moving it to 
`shared/` or `airflow/utils/` might prevent subtle bugs like this one. What do 
you think?
   
   <img width="550" height="308" alt="image" 
src="https://github.com/user-attachments/assets/21d39f96-f6f2-49e4-94a2-4526e1af25fd";
 />



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to