seanghaeli commented on code in PR #66608:
URL: https://github.com/apache/airflow/pull/66608#discussion_r3314277619
##########
airflow-core/src/airflow/models/deadline.py:
##########
@@ -215,45 +215,22 @@ def prune_deadlines(cls, *, session: Session, conditions:
dict[Mapped, Any]) ->
def handle_miss(self, session: Session):
"""Handle a missed deadline by queueing the callback."""
+ # DagRun identifiers at top level for routing (triggerer/executor uses
these to fetch context).
+ self.callback.data["dag_id"] = self.dagrun.dag_id
+ self.callback.data["run_id"] = self.dagrun.run_id
Review Comment:
I see your point, the full fix would require db migration and I think we can
deal with that in a later problem if it surfaces again. For now, I left a
comment explaining:
https://github.com/aws-mwaa/upstream-to-airflow/blob/ghaeli/callback-context-execution-api/airflow-core/src/airflow/models/deadline.py#L221-L227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
