seanghaeli commented on code in PR #66608:
URL: https://github.com/apache/airflow/pull/66608#discussion_r3326996355
##########
task-sdk/src/airflow/sdk/execution_time/callback_supervisor.py:
##########
@@ -305,6 +327,50 @@ def _handle_request(self, msg: CallbackToSupervisor, log:
FilteringBoundLogger,
self.send_msg(resp, request_id=req_id, error=None, **dump_opts)
+def _register_unusual_prefix_module(callback_path: str, bundle_path, _log) ->
None:
Review Comment:
Follow-up: moved the shared helper to `airflow._shared.module_loading` as
`load_mangled_dag_module` (alongside `import_string`) so both sides can import
it cleanly — `airflow-core` via `airflow._shared.module_loading` and `task-sdk`
via `airflow.sdk._shared.module_loading` (the two symlinked namespaces for the
same shared source). This resolved the `SDK001` static check violation that
would have occurred from `airflow-core/triggers/callback.py` importing from
`task-sdk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
