jason810496 opened a new pull request, #67635: URL: https://github.com/apache/airflow/pull/67635
* related: https://github.com/apache/airflow/pull/65958 * https://github.com/apache/airflow/pull/67161 * https://github.com/apache/airflow/issues/66838#issuecomment-4495952571 ## Why The upcoming `ExecutableCoordinator` (https://github.com/apache/airflow/pull/67161, launching any executable of compiled language) for Go-SDK will leverage exact same way to start the subprocess from coordinator. We should introduce a common `SocketCoordinator` (any better naming is welcome) for both `JavaCoordinator` and `ExecutableCoordinator`. ## What - Add `SocketCoordinator` and corresponding unit tests - The method to override by subclass: `def _build_execute_task_command(self, *, what: TaskInstanceDTO) -> tuple[list[str], str | None]:` - The first returned `list[str]` is the subprocess command args without `--logs` and `--comms`. - The second returned`str` is subprocess supervisor version. - Make `JavaCoordinator` inherit `SocketCoordinator` --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes (please specify the tool below) with help of Claude Ops 4.7 following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
