SameerMesiah97 commented on code in PR #67524:
URL: https://github.com/apache/airflow/pull/67524#discussion_r3329265289
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/dms.py:
##########
@@ -219,3 +222,79 @@ def hook(self) -> AwsGenericHook:
verify=self.verify,
config=self.botocore_config,
)
+
+
+class DmsTaskModifyCompleteTrigger(BaseTrigger):
Review Comment:
Just curious here. Why are you inheriting from `BaseTrigger` instead of
`AwsBaseWaiterTrigger`? Could this trigger still inherit from
`AwsBaseWaiterTrigger` and override the polling/state-machine behavior i.e. the
`run `method? It seems like most of the AWS-specific plumbing is still
applicable, and only the waiter lifecycle handling differs. You may override
anything else you need to get this to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
