AlejandroMorgante commented on code in PR #67524:
URL: https://github.com/apache/airflow/pull/67524#discussion_r3329288696
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/dms.py:
##########
@@ -219,3 +222,79 @@ def hook(self) -> AwsGenericHook:
verify=self.verify,
config=self.botocore_config,
)
+
+
+class DmsTaskModifyCompleteTrigger(BaseTrigger):
Review Comment:
`AwsBaseWaiterTrigger` relies on boto3 waiters, but both the
`ReplicationTaskReady` and `ReplicationTaskStopped` boto3 waiters explicitly
treat `modifying` as a terminal `failure` state — they'd error out the moment
the task enters modification. There's no boto3 waiter that waits for a task to
*exit* `modifying`, so a custom polling loop with `BaseTrigger` is necessary
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
