wjddn279 opened a new pull request, #67887: URL: https://github.com/apache/airflow/pull/67887
related: https://github.com/apache/airflow/pull/67679#discussion_r3323352577 ### Body In the Edge worker fork path, `_run_job_via_supervisor` runs as a `multiprocessing.Process` target. It returned an `int` exit code, but multiprocessing ignores a target's return value and sets the child's exit code to `0` on any normal return. So when the supervisor exited abnormally (crash, kill, or a failed terminal-state delivery — a non-zero `run_workload` result), the forked child still exited `0`, and the parent's `Job.is_success` (`exitcode == 0`) reported the failed job as **success**. This propagates the supervisor's exit code via `sys.exit()` so the child's exit status reflects the real outcome and the failure-handling branch (`failure_details()` + log push + `FAILED` state) runs as intended. #### note this fix only makes errors in the supervisor itself be treated as failures; it does not correctly detect failures of the user-defined task that the supervisor runs. In those cases, the edge job stays marked as success. ### Question A normal task failure (user code raising) is reported by the supervisor through the Execution API and the subprocess exits `0` that path is unchanged here and the task instance is still correctly marked `FAILED`. So while the task instance state is updated correctly, the edge job is still marked as success even when the task fails, and it also shows up as success in the edge executor's job list UI. Is this intended behavior? <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [x] Yes (please specify the tool below) claude opus <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
