phanikumv commented on code in PR #67826:
URL: https://github.com/apache/airflow/pull/67826#discussion_r3339092913
##########
.github/workflows/ci-arm.yml:
##########
@@ -964,18 +970,51 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd #
v6.0.2
with:
persist-credentials: false
- # keep this in sync with the jvmTarget in java-sdk/build.gradle.kts
- name: Setup Java
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 #
v5.2.0
with:
distribution: 'temurin'
- java-version: '11'
+ java-version: ${{ env.JAVA_VERSION }}
- name: "Cleanup dist files"
run: rm -fv ./dist/*
- name: Run Java SDK tests
working-directory: ./java-sdk
run: ./gradlew test
+ build-java-sdk-docs:
Review Comment:
The new `build-java-sdk-docs` job might break docs republishing for older
release tags/branches.
This workflow republishes docs for whatever release ref a release manager
passes. The new job (line 348) checks out that ref and runs `./gradlew
:sdk:dokkaGeneratePublicationHtml`, and the publish step `needs:` it with no
fallback (line 394).
But the Java SDK only exists on recent `main` — not in any released tag — so
republishing an older ref's docs fails at this job and cancels the whole
publish, Python docs included.
The CI workflows already handle this: they only run the Java step when the
SDK is present and let later steps continue if it's skipped. Could we do the
same here?
Not a merge blocker for me — let me know if I'm missing a reason it's
already safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
