nailo2c commented on code in PR #67873:
URL: https://github.com/apache/airflow/pull/67873#discussion_r3368337049
##########
airflow-core/tests/unit/ti_deps/deps/test_trigger_rule_dep.py:
##########
@@ -1509,6 +1516,51 @@ def
test_mapped_task_upstream_removed_with_none_failed_trigger_rules(
_test_trigger_rule(ti=ti, session=session,
flag_upstream_failed=flag_upstream_failed)
+ @pytest.mark.flaky(reruns=5)
Review Comment:
I added it because I noticed that there are three functions in this file
have flaky flag: [e.g.
1](https://github.com/apache/airflow/blob/main/airflow-core/tests/unit/ti_deps/deps/test_trigger_rule_dep.py#L1444)
/ [e.g.
2](https://github.com/apache/airflow/blob/33c956392970d2821532e4374d59f5eede89e5ba/airflow-core/tests/unit/ti_deps/deps/test_trigger_rule_dep.py#L1476)
/ [e.g.
3](https://github.com/apache/airflow/blob/33c956392970d2821532e4374d59f5eede89e5ba/airflow-core/tests/unit/ti_deps/deps/test_trigger_rule_dep.py#L1841)
So I thought I should add it too, since it seems easy to encounter race
conditions in trigger rules in CI. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
