shahar1 commented on code in PR #67873:
URL: https://github.com/apache/airflow/pull/67873#discussion_r3363843723
##########
airflow-core/src/airflow/ti_deps/deps/trigger_rule_dep.py:
##########
@@ -549,6 +549,14 @@ def _evaluate_direct_relatives() -> Iterator[TIDepStatus]:
f"upstream_task_ids={task.upstream_task_ids}"
)
)
+ elif trigger_rule == TR.NONE_FAILED_MIN_ONE_SUCCESS and
success <= 0:
Review Comment:
You have above `elif trigger_rule == TR.NONE_FAILED or trigger_rule ==
TR.NONE_FAILED_MIN_ONE_SUCCESS:`, so it seems rather confusing to check it
twice.
Maybe you could rewrite both so eventually you'll have
````python
elif trigger_rule == TR.NONE_FAILED:
...
elif trigger_rule == TR.NONE_FAILED_MIN_ONE_SUCCES:
...
````
##########
airflow-core/tests/unit/ti_deps/deps/test_trigger_rule_dep.py:
##########
@@ -1509,6 +1516,51 @@ def
test_mapped_task_upstream_removed_with_none_failed_trigger_rules(
_test_trigger_rule(ti=ti, session=session,
flag_upstream_failed=flag_upstream_failed)
+ @pytest.mark.flaky(reruns=5)
Review Comment:
Why do we need the flaky flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
