Vamsi-klu commented on PR #68144: URL: https://github.com/apache/airflow/pull/68144#issuecomment-4643801157
Thanks for the thorough review, @Nataneljpwd! Pushed a follow-up commit addressing everything: - **Removed the `transport_mode` connection-extra special-casing** — the `HIVE_CLI_TRANSPORT_MODES` constant, the form widget, and `_get_connection_jdbc_url_parameters`. `transportMode` is now passed like any other param via `jdbc_params`, so there's a single sanctioned, validated injection point (resolves the lines 53/152/239/240 threads). - **Consolidated the six helpers into one `_append_jdbc_params`** that validates name and value inline in a single pass (lines 229/256/265). - **Tightened the name regex** to `^[A-Za-z]([A-Za-z0-9._-]*[A-Za-z0-9])?$` so names can't end in `.`, `-`, or `_`, with tests for those cases (line 54). - **Docs**: removed the Transport Mode entry and the "fixed connection extras" paragraph, and added the regex (lines 84/106/108). - The valid-case behaviour is asserted by `test_jdbc_params_append_to_beeline_url` and friends (line 713). - Also dropped the manual `changelog.rst` entry, since provider changelogs are regenerated from `git log` by the release manager. On the use-case question (line 273): `jdbc_params` is the only place a DAG author can inject Cloudera-CDP-style JDBC params, since the Beeline URL is assembled programmatically and there's no author-editable raw-URL field — more detail in that thread. --- Drafted-by: Claude Code (Opus 4.8) (no human review before posting) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
