Vamsi-klu commented on code in PR #68144:
URL: https://github.com/apache/airflow/pull/68144#discussion_r3369969810
##########
providers/apache/hive/docs/connections/hive_cli.rst:
##########
@@ -80,9 +80,36 @@ High Availability (optional)
Ssl (optional)
Specify as ``True`` to enable SSL for your high availability connection.
+Transport Mode (optional)
+ Specify the JDBC ``transportMode`` parameter. Supported values are
``binary`` and ``http``.
+
Zoo Keeper Namespace (optional)
Zoo keeper namespace for high availability.
+Additional JDBC Parameters
+--------------------------
+
+Dag authors can pass additional Beeline JDBC URL parameters to ``HiveCliHook``
or ``HiveOperator``
+with the ``jdbc_params`` argument:
+
+.. code-block:: python
+
+ HiveCliHook(
+ jdbc_params={
+ "transportMode": "http",
+ "sslTrustStore": "/opt/hive/truststore.jks",
+ "trustStorePassword": "secret",
+ }
+ )
+
+These parameters are appended to the Beeline JDBC URL. Parameter names must
start with a letter
+and contain only letters, digits, dots, underscores, or hyphens. Values must
not contain semicolons.
+
+Arbitrary JDBC parameters are not read from connection extras. Only fixed
connection extras with
Review Comment:
Good questions. With the `transport_mode` special-casing removed, that
paragraph no longer applies: arbitrary JDBC params are **not** read from
connection extras at all — `jdbc_params` (supplied through the hook/operator)
is the only source. I removed the "fixed connection extras / bounded values"
paragraph, and the section now states exactly that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
