amoghrajesh opened a new pull request, #68206:
URL: https://github.com/apache/airflow/pull/68206
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes: claude sonnet 4.6
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
### What
If/When `ResumableJobMixin` fails in a running cluster in production, for
reasons such as: stale state, a resume that silently falls back to a fresh
submit, or a wrong external job ID, there is not enough signal in the logs to
diagnose the failure from telemetry alone. Support and engineering will have to
reproduce the issue to understand what happened.
### Current behaviour
`execute_resumable()` emits three `INFO` log lines using positional `%s`
formatting. None of them include the external ID key, and the terminal-state
fallback (where the operator silently resubmits fresh instead of reconnecting)
is logged at `INFO` which indistinguishable from the normal path. When
`task_store` is absent from context (pre-3.3 workers or misconfigured
environments), nothing is logged.
### Proposed change
- Enhance existing log lines to use structlog keyword args for logging
(`external_id=`, `external_id_key=`, `status=`) so the fields are queryable in
structured log systems.
- Some edits to the terminal-state fallback log from `INFO` to `WARNING`,
this is a degraded path that warrants attention.
- Added a `WARNING` when `task_store` is not available in context, making it
visible when crash recovery is silently disabled.
- Added `DEBUG` logs for the fresh-submit and post-persist paths (internal
mechanics, off by default in production).
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
