dabla opened a new pull request, #68207:
URL: https://github.com/apache/airflow/pull/68207
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
## Summary
This PR optimizes `PostgresHook.insert_rows()` when `fast_executemany=True`
by switching from `execute_batch` to `execute_values` for psycopg2, which
provides significantly better bulk insert performance.
## Changes
- **psycopg2 with `fast_executemany=True`**: Now uses
`psycopg2.extras.execute_values()` instead of `execute_batch()`. This batches
all rows into a single `INSERT` statement with multiple value tuples, reducing
round-trips and improving throughput.
- **psycopg3**: Falls back to the default `DbApiHook.insert_rows()`
implementation. psycopg3's native `executemany` already uses pipelining
internally, so there's no benefit to a custom implementation—and
`execute_values` is not compatible with psycopg3.
- **Format string handling**: Both code paths now explicitly set
`_insert_statement_format` to ensure correct SQL generation and self-healing if
a previous call failed mid-execution.
## Why execute_values over execute_batch?
| Method | Behavior |
|--------|----------|
| `execute_batch` | Sends multiple `INSERT` statements in batches |
| `execute_values` | Sends a single `INSERT ... VALUES (...), (...), (...)`
statement |
`execute_values` is typically 2-3x faster for bulk inserts because it
minimizes statement parsing overhead and network round-trips.
## Testing
- Updated existing tests to verify `execute_values` is called instead of
`execute_batch`
- Added new test to verify psycopg3 correctly falls back to the default
implementation even when `fast_executemany=True`
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
