kacpermuda commented on code in PR #65618:
URL: https://github.com/apache/airflow/pull/65618#discussion_r3372192751
##########
providers/common/sql/src/airflow/providers/common/sql/operators/sql.py:
##########
@@ -513,6 +517,7 @@ def __init__(
return_last: bool = True,
show_return_value_in_logs: bool = False,
requires_result_fetch: bool = False,
+ deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
Review Comment:
Small note / question. We should probably mark this somewhere in the
changelog / release notes, to underline that SQlExecuteQueryOperator can now be
deferrable and it uses this global config. I assume not all the hooks will be
compatible on day 0, and if somebody is using config of
"default_deferrable=True", it can break their workflow (correct?). Wondering if
this should be a "breaking" change or we just assume it's a feature, and if
somebody is using "default_deferrable=True" = they know what they're doing. Was
just thinking that there were no major changes to this operator for a long time
and it's a crucial one, so such change can have a big impact on the end users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
