kacpermuda commented on code in PR #65618:
URL: https://github.com/apache/airflow/pull/65618#discussion_r3381354546
##########
providers/common/sql/src/airflow/providers/common/sql/operators/sql.py:
##########
@@ -513,6 +517,7 @@ def __init__(
return_last: bool = True,
show_return_value_in_logs: bool = False,
requires_result_fetch: bool = False,
+ deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
Review Comment:
I think there is no requirement to wait until major version release, it can
happen anytime based on the gravity of changes added, but I guess this operator
is so widely used that breaking it may be very annoying, even with clear error
message, requiring action from majority of users is not a great idea. Maybe a
better solution would be to just not use the global `[operators.
default_deferrable]` here and use False by default, this way we make it a clear
opt-in for users. If we document the reasoning behind this, it should be clear
for users and developers why the global config is not used yet. Then, when the
coverage improves for async hooks, we can re-visit this operator, switch to
using global config as default and then do a major release, when the coverage
of async db hooks is already substantial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
