[
https://issues.apache.org/jira/browse/AIRFLOW-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006166#comment-17006166
]
ASF GitHub Bot commented on AIRFLOW-6392:
-----------------------------------------
nuclearpinguin commented on pull request #6950: [AIRFLOW-6392] Remove cyclic
dependency baseoperator <-> helpers
URL: https://github.com/apache/airflow/pull/6950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove cyclic module dependency airfllow.models.baseoperator <->
> airflow.utils.helpers
> --------------------------------------------------------------------------------------
>
> Key: AIRFLOW-6392
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6392
> Project: Apache Airflow
> Issue Type: Improvement
> Components: ci
> Affects Versions: 2.0.0
> Reporter: Jarek Potiuk
> Priority: Major
>
> There is a hidden cyclic dependency between baseoperator and helpers module.
> It's hidden by local import but it is detected when baseoperator/helpers are
> removed from pylint_todo.txt (and it's really there).
> The dependency comes from BaseOperator using helpers and two helpers methods
> (chain and cross_downstream) using BaseOperator. This can be solved by
> converting the chain and cross_downstream methods to be static methods in
> BaseOperator class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
