[ 
https://issues.apache.org/jira/browse/AIRFLOW-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006168#comment-17006168
 ] 

ASF subversion and git services commented on AIRFLOW-6392:
----------------------------------------------------------

Commit e9e0203ebc002086b9bc94f3be1c15508ec21639 in airflow's branch 
refs/heads/master from Jarek Potiuk
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=e9e0203 ]

[AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers (#6950)

There is a hidden cyclic dependency between baseoperator and helpers module.
It's hidden by local import but it is detected when baseoperator/helpers are
removed from pylint_todo.txt (and it's really there).

The dependency comes from BaseOperator using helpers and two helpers methods
(chain and cross_downstream) using BaseOperator. This can be solved by
converting the chain and cross_downstream methods to be static methods in
BaseOperator class.

> Remove cyclic module dependency airfllow.models.baseoperator <-> 
> airflow.utils.helpers
> --------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6392
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6392
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: ci
>    Affects Versions: 2.0.0
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> There is a hidden cyclic dependency between baseoperator and helpers module. 
> It's hidden by local import but it is detected when baseoperator/helpers are 
> removed from pylint_todo.txt (and it's really there). 
> The dependency comes from BaseOperator using helpers and two helpers methods 
> (chain and cross_downstream) using BaseOperator. This can be solved by 
> converting the chain and cross_downstream methods to be static methods in 
> BaseOperator class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to