jscheffl commented on code in PR #68198:
URL: https://github.com/apache/airflow/pull/68198#discussion_r3375868367
##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -618,7 +591,7 @@ def create_dagrun(
data_interval=data_interval,
run_after=coerce_datetime(run_after),
start_date=coerce_datetime(start_date),
- conf=conf,
+ conf=conf if conf is not None else dict(copied_params),
Review Comment:
You can have an easier syntax:
```suggestion
conf=conf or dict(copied_params),
```
...but as also dag runs do not carry a conf or params in case it is
scheduled - having and empty conf is more consistent than taking over param
details here. Would be a behaviour change that needs broader visibility. I
think consumers must assume given conf is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
