dheerajturaga commented on code in PR #68198:
URL: https://github.com/apache/airflow/pull/68198#discussion_r3375926117


##########
airflow-core/src/airflow/serialization/definitions/dag.py:
##########
@@ -618,7 +591,7 @@ def create_dagrun(
             data_interval=data_interval,
             run_after=coerce_datetime(run_after),
             start_date=coerce_datetime(start_date),
-            conf=conf,
+            conf=conf if conf is not None else dict(copied_params),

Review Comment:
   @jscheffl, should we kick this out from this PR in that case? CI failure is 
primarily due to this and its needed to be able to use this for scheduled runs. 
   One thing to note is that the queue override through params is mostly a 
manual run usecase. If I want to override via a scheduled run, I can modify the 
dag anyway. 
   
   The `TriggerDagRunOperator` would also work without this addition as its 
similar to a manual trigger. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to