uranusjr commented on code in PR #67475:
URL: https://github.com/apache/airflow/pull/67475#discussion_r3378218379
##########
airflow-core/src/airflow/partition_mappers/window.py:
##########
@@ -88,16 +99,19 @@ class Window(ABC):
#: but the window needs a different type. Temporal windows declare
``datetime``.
expected_decoded_type: ClassVar[type] = str
+ def __init__(self, *, direction: WindowDirection =
WindowDirection.FORWARD) -> None:
+ self.direction = direction
Review Comment:
Should this input be validated? A mistype can break a lot of things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
