Lee-W commented on code in PR #67475: URL: https://github.com/apache/airflow/pull/67475#discussion_r3380706669
########## task-sdk/src/airflow/sdk/definitions/partition_mappers/window.py: ########## @@ -14,10 +14,28 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. + +# Keep the following in sync with the core copy in +# ``airflow-core/src/airflow/partition_mappers/window.py`` — +# the SDK and core class hierarchies are independent (the SDK cannot import +# core), so both sides carry the same definitions. Runtime logic lives in the +# core copy; this file provides the author-facing classes used at Dag-parse time. +# Synced items: all class names, ``WindowDirection``, ``direction`` kwarg, ``serialize``/``deserialize``. from __future__ import annotations from datetime import datetime -from typing import ClassVar +from enum import Enum +from typing import Any, ClassVar + + +class WindowDirection(str, Enum): Review Comment: I made it `Window.Direction`. I'm not a super huge fan of this interface. But I like the fact that we group similar concepts together -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
