jykae commented on code in PR #68074:
URL: https://github.com/apache/airflow/pull/68074#discussion_r3387219780
##########
chart/newsfragments/68074.significant.rst:
##########
@@ -0,0 +1,37 @@
+Helm chart now reconciles the Airflow metadata DB bidirectionally on ``helm
upgrade``
+
+The ``migrate-database-job`` is now run as a ``post-install,pre-upgrade`` hook
+(was ``post-install,post-upgrade``) and its default args run a reconciliation
+script that picks one of four actions depending on the relationship between
+the chart's ``airflowVersion`` and the alembic head currently in the database:
+
+* ``fresh install`` (no alembic row, or DB unreachable) — ``airflow db
migrate``.
Review Comment:
Good catch. Updated the newsfragment to match the implementation: the action
is only decided once the DB is reachable, and if it's still unreachable after
the connection-wait window (`DB_CONNECT_MAX_WAIT_SECONDS`, default 120) the job
exits non-zero and is retried via the Job `backoffLimit` rather than proceeding
with a migrate.
##########
chart/templates/rbac/migrate-database-job-role.yaml:
##########
@@ -0,0 +1,82 @@
+{{/*
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/}}
+
+#######################################
+## Airflow Migrate Database Job Role
+##
+## Grants pods + pods/exec in the release namespace so the migrate-database-job
+## can exec ``airflow db downgrade`` inside the still-running api-server pod on
+## a chart downgrade. The forward-migrate branch never uses these permissions.
+#######################################
+{{- if and .Values.rbac.create .Values.migrateDatabaseJob.enabled }}
+apiVersion: rbac.authorization.k8s.io/v1
+kind: Role
+metadata:
+ name: {{ include "airflow.fullname" . }}-migrate-database-job-role
+ namespace: "{{ .Release.Namespace }}"
+ labels:
+ tier: airflow
+ component: run-airflow-migrations
+ release: {{ .Release.Name }}
+ chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+ heritage: {{ .Release.Service }}
+ {{- with .Values.labels }}
+ {{- toYaml . | nindent 4 }}
+ {{- end }}
+ {{- if .Values.migrateDatabaseJob.useHelmHooks }}
+ annotations:
+ helm.sh/hook: post-install,pre-upgrade
+ helm.sh/hook-weight: "-5"
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+ {{- end }}
+rules:
+ - apiGroups:
+ - ""
+ resources:
+ - "pods"
+ verbs:
+ - "get"
+ - "list"
+ - apiGroups:
+ - ""
+ resources:
+ - "pods/exec"
+ verbs:
+ - "create"
+ - "get"
Review Comment:
Tightened the Role to least privilege:
- `pods/exec` now grants only `get`. The reconciler execs via
`connect_get_namespaced_pod_exec`, which is an HTTP GET to the exec
subresource, so the API server authorizes it under `get` (not `create`, which a
POST-based exec would need). Added a comment documenting this.
- `deployments/scale` and `statefulsets/scale` now grant only `patch` — the
reconciler patches replicas to 0 and never reads the scale subresource back.
Added a comment as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
