jykae commented on PR #68074: URL: https://github.com/apache/airflow/pull/68074#issuecomment-4679401152
> > Took me a moment to read and igest the idea. First I was a bit reluctant but then reading more and having some hours of thought I really like the idea. > > Some comments besides CI is not getting green - probably you find the bug. > > I see this as a very cool improvement the more I think about this and would like to vote for having this. Downgrade with Helm was always a pain. This PR addresses this. > > What do other reviewers think about it? @bugraoz93 @jedcunningham @Miretpl @potiuk ? > > I very much agree with Jens! This would be a great feature to have. It is a huge LoC, but once you update your environment, you always try to make it work rather than reverting, since sometimes it is harder to return back,. This could help with rolling back updates. My only concern is the testability of the script. We should test them in one of the integration tests. Unit tests don't reflect what would happen in the environment; even integration tests don't fully, but it would be great comfort if we had it. I haven't taken a deep dive to check if it is easy to achieve. This one `chart/files/db_migrate.py` As @bugraoz93 pointed out having E2E tests for each path would be really cool to have, currently just existing forward path and fresh install are covered if noticed correct from tests ? can you take on further E2E testing for this as I dont know that much this project test setups -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
