Dev-iL commented on code in PR #68314:
URL: https://github.com/apache/airflow/pull/68314#discussion_r3387325677
##########
.pre-commit-config.yaml:
##########
@@ -1176,6 +1176,21 @@ repos:
files: ^airflow-core/src/airflow/migrations/versions/.*\.py$
additional_dependencies: [rich>=13.6.0]
require_serial: true
+ - id: check-postgres-driver-explicit
+ name: Forbid bare postgresql:// without explicit driver (SQL001)
+ entry: ./scripts/ci/prek/check_postgres_driver_explicit.py
+ language: python
+ pass_filenames: true
+ files: >
+ (?x)
+ ^airflow-core/src/.*\.(py|cfg)$|
+ ^airflow-core/docs/howto/set-up-database\.rst$|
+ ^devel-common/src/.*\.cfg$|
+ ^task-sdk-integration-tests/docker-compose\.yaml$
+ exclude: >
+ (?x)
+ ^scripts/ci/prek/check_postgres_driver_explicit\.py$
+ additional_dependencies: [rich>=13.6.0]
Review Comment:
The reason for the hook is so that contributors don't introduce new
instances of the implicit pattern to the codebase after this is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]