potiuk commented on code in PR #68304:
URL: https://github.com/apache/airflow/pull/68304#discussion_r3394829529
##########
airflow-core/src/airflow/config_templates/config.yml:
##########
@@ -779,6 +779,18 @@ logging:
type: string
example: ~
default: "False"
+ object_store_write_mode:
Review Comment:
Is not that purely S3 configuration? It should be added as amazon
configuration entry (in provider.yaml), not logging configuration in airflow
core - the way it is added now is just quite wrong as it is only implemented in
S3 handler now - but it talks about "remote log handlers".
So either we make it "amazon" only - and move configuration there - or we
make corresponding changes in all other providers that implement remote logging
(or even better - not sure if possible) - we implement a common way of handling
it in the core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
