jvstein commented on code in PR #68304:
URL: https://github.com/apache/airflow/pull/68304#discussion_r3397277749


##########
providers/amazon/src/airflow/providers/amazon/aws/log/s3_task_handler.py:
##########
@@ -121,7 +119,7 @@ def write(
         try:
             if append and self.s3_log_exists(remote_log_location):
                 old_log = self.s3_read(remote_log_location)
-                if old_log:
+                if old_log and not log.startswith(old_log):

Review Comment:
   I think for my use case (the former), I can set `delete_local_logs=True`. 
Which is effectively the same as truncating. But that doesn't solve the case of 
log duplication in the latter case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to