amoghrajesh opened a new pull request, #68394:
URL: https://github.com/apache/airflow/pull/68394
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes claude sonnet
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
**PR Description:**
### What
The "Custom" expiration option in the Add/Edit Task Store modal was stubbed
out and disabled, with a TODO comment waiting for a datetime picker component.
`DateTimeInput` already existed but wasn't wired up.
<img width="1978" height="1512" alt="image (89)"
src="https://github.com/user-attachments/assets/ab92af8d-fee4-4e71-98df-4b8eb0ead489";
/>
### Current behaviour
The "Custom" radio card in the Expiration section is disabled. Users can
only choose "Default (30 days)" or "Never" — there is no way to set an
arbitrary expiration datetime via the UI.
### Proposed change
Enables the "Custom" option and renders a `DateTimeInput` below the radio
group when it is selected. The picker respects the user's selected Airflow
timezone and enforces a `min` of the current time so past datetimes cannot be
chosen. The selected datetime is sent to the core API as an ISO 8601 string.
Edit mode hydrates the picker correctly when an existing entry has a specific
`expires_at`.
The Save button remains disabled until a date is entered when "Custom" is
selected.
### Testing
Adding a new task store
<img width="2554" height="1049" alt="image"
src="https://github.com/user-attachments/assets/e3275534-ee16-4f4f-a4c6-dae29ea39bc3";
/>
After its added
<img width="2554" height="1049" alt="image"
src="https://github.com/user-attachments/assets/5934fb86-e8e1-41cc-85a3-6fe09ba68be4";
/>
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
