Lee-W commented on code in PR #68326:
URL: https://github.com/apache/airflow/pull/68326#discussion_r3401481919
##########
airflow-core/tests/unit/timetables/test_base_timetable.py:
##########
@@ -183,6 +183,46 @@ def
test_compute_rollup_fingerprint_key_format(asset_or_ref, expected_key):
assert expected_key in fp
+# ---------------------------------------------------------------------------
+# DagRunInfo partition fields
+# ---------------------------------------------------------------------------
+
+
+def test_dagruninfo_partition_fields_default_to_none():
Review Comment:
these 2 tests can be parameterized
##########
airflow-core/tests/unit/timetables/test_base_timetable.py:
##########
@@ -183,6 +183,46 @@ def
test_compute_rollup_fingerprint_key_format(asset_or_ref, expected_key):
assert expected_key in fp
+# ---------------------------------------------------------------------------
+# DagRunInfo partition fields
+# ---------------------------------------------------------------------------
+
+
+def test_dagruninfo_partition_fields_default_to_none():
+ """``DagRunInfo`` can be constructed with only ``run_after`` and
+ ``data_interval``; the partition fields are optional and default to
*None*."""
+ from airflow.timetables.base import DagRunInfo, DataInterval
+
Review Comment:
we can move it to the top level import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
