Abdulrehman-PIAIC80387 commented on PR #68326: URL: https://github.com/apache/airflow/pull/68326#issuecomment-4688894548
Hi @Lee-W, thanks for the review! Addressed all three points in commit 00cae3090a: - Removed the comment block above the tests. - Parameterized the two tests into a single `test_dagruninfo_partition_fields` (covering both the omitted → defaults-to-None case and the explicitly-set case). - Moved the `DagRunInfo` / `DataInterval` import to the top level. I also see #68342 covers the same `base.py` fix and is closer to merging — happy for that to land first and keep this PR as the extended test coverage (I'll rebase to drop the now-redundant `base.py` change). Any further feedback is welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
