ferruzzi commented on PR #68106: URL: https://github.com/apache/airflow/pull/68106#issuecomment-4694593733
@ashb I strongly disagree and would rather you discuss it instead of rejecting the PR and closing the Issue. The PR as it stands doesn't enforce the message type checking, but that is trivial to fix since every Process already declares which types it can accept int he decoder (`ToSupervisor`, `CallbackToSupervisor`, etc). Checking if the message type against that list of allowed messages is trivial (and does need to be added) Some of the shared message handlers are already moved to a central location and having them all in one canonical place makes way more sense than having them spread out. Assuming the code is updated to enforce the decoder's message allow-list, I don't see your objection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
