1fanwang commented on code in PR #68512:
URL: https://github.com/apache/airflow/pull/68512#discussion_r3409011457
##########
airflow-core/src/airflow/api_fastapi/common/exceptions.py:
##########
@@ -108,51 +129,20 @@ def _is_dialect_matched(self, exc: IntegrityError) ->
bool:
return False
Review Comment:
`_is_dialect_matched` reads `unique_constraint_error_prefix_dict` and sets
`self.dialect`, both specific to this handler. In the base it would be dead
weight for `DataErrorHandler`, which has no prefixes and handles every
`DataError` unconditionally — and the base would carry unique-constraint
signatures it cannot generally use. The shared hook it plugs into,
`_should_handle`, already lives in the base. Did you have a generalization in
mind that would serve both handlers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
