1fanwang commented on code in PR #68512:
URL: https://github.com/apache/airflow/pull/68512#discussion_r3409011457
##########
airflow-core/src/airflow/api_fastapi/common/exceptions.py:
##########
@@ -108,51 +129,20 @@ def _is_dialect_matched(self, exc: IntegrityError) ->
bool:
return False
Review Comment:
I looked at moving it and hit a snag: `_is_dialect_matched` leans on
`unique_constraint_error_prefix_dict` and `self.dialect`, which only this
handler has, so `DataErrorHandler` would inherit a matcher it never calls. Were
you picturing a generic prefix-match the base owns and each handler opts into?
Want to make sure I build the right thing rather than guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
