henry3260 commented on code in PR #64523:
URL: https://github.com/apache/airflow/pull/64523#discussion_r3415842948
##########
airflow-core/src/airflow/observability/metrics/stats_utils.py:
##########
@@ -23,6 +23,16 @@
from airflow.configuration import conf
+def is_metrics_enabled() -> bool:
+ return any(
+ (
+ conf.getboolean("metrics", "statsd_datadog_enabled",
fallback=False),
Review Comment:
> Don't need this, that only works if `statsd_on` is true.
`statsd_datadog_enabled` currently works independently of `statsd_on`.
`get_stats_factory`() checks it first
Am I missing another gating condition?
https://github.com/apache/airflow/blob/ecc04df016e4f514bcb29e074f7b0ccba53d4d1b/airflow-core/src/airflow/observability/metrics/stats_utils.py#L26-L36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
