henry3260 commented on code in PR #64523:
URL: https://github.com/apache/airflow/pull/64523#discussion_r3415965092
##########
airflow-core/tests/unit/api_fastapi/common/test_http_access_log.py:
##########
@@ -55,12 +52,24 @@ async def homepage(request):
raise RuntimeError("boom")
return PlainTextResponse("ok")
+ async def api_item(request):
+ return PlainTextResponse("ok")
+
+ async def ui_item(request):
+ return PlainTextResponse("ok")
+
+ async def api_fail(request):
+ raise RuntimeError("boom")
+
Review Comment:
> New test cases, but nothing exercising them/changed about the assertions
is a code smell.
Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
