o-nikolas commented on code in PR #68367:
URL: https://github.com/apache/airflow/pull/68367#discussion_r3416104837
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -397,7 +397,12 @@ def register_asset_change(
)
)
- stats.incr("asset.updates")
+ team_name = None
+ if task_instance and conf.getboolean("core", "multi_team"):
+ from airflow.models.dag import DagModel
+
+ team_name = DagModel.get_team_name(task_instance.dag_id,
session=session)
Review Comment:
> I will remove the call on L413 and reuse the existing value from L404,
which may or may not be what you are concerned about.
I was mostly concerned with just repeated executions of this code path (not
the double call you had, but agree it's tidier to just call once and re-use).
How often does this code path run? Do we know? Maybe a question for
@vincbeck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
