Lee-W commented on code in PR #67285:
URL: https://github.com/apache/airflow/pull/67285#discussion_r3420084830
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -639,9 +648,21 @@ def _queue_partitioned_dags(
)
continue
+ # Carry the producer's partition_date onto the APDR for
IdentityMapper
+ # only: its key carries no temporal meaning, so the scheduler
cannot
+ # re-derive the date at run creation and the producer's date
(threaded
+ # in from its DagRun via register_asset_change) must be carried
here.
+ # Temporal and composite mappers are resolved from the key by the
+ # scheduler via PartitionMapper.to_partition_date, so this is None
for
+ # them.
+ target_partition_date: datetime | None = (
+ partition_date if isinstance(mapper, IdentityMapper) else None
Review Comment:
Is it possible to make it part of IdentityMapper.to_partition_date somehow?
would be better if we could avoid `isinstance`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
