nathadfield commented on code in PR #67285:
URL: https://github.com/apache/airflow/pull/67285#discussion_r3421192730
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py:
##########
@@ -2690,6 +2695,7 @@ def test_should_respond_200_with_null_logical_date(self,
test_client):
"conf": {},
"note": None,
"partition_key": None,
+ "partition_date": None,
Review Comment:
@Lee-W good call. I've set a real `partition_date` on one of the fixture
DagRuns (the one with the date-shaped key), so the GET and list responses now
assert the serialized non-None value through `get_dag_run_dict`, not just
`None`. The POST/create tests stay `None` since a manual trigger doesn't carry
a `partition_date`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
