dingo4dev commented on code in PR #62501:
URL: https://github.com/apache/airflow/pull/62501#discussion_r3432705791
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -137,6 +138,44 @@ def _add_one(asset: SerializedAsset) -> AssetModel:
return [_add_one(a) for a in assets]
+ @classmethod
+ def create_asset_event(cls, *, session: Session, **event_kwargs) ->
AssetEvent:
Review Comment:
You’re absolutely right that this function doesn't rely on any state within
the manager class. I implemented this function inside the manager class as it
might belong to the asset manager and might align with other functions inside
it tho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]