pierrejeambrun opened a new pull request, #68893:
URL: https://github.com/apache/airflow/pull/68893

   The dashboard alert "See more"/"See less" clamp behaves incorrectly: a long 
markdown alert shows no "See more" (its text is never clamped), while a short 
single-line alert shows a "See more" that reveals nothing when clicked.
   
   Root cause: the clamp used `-webkit-line-clamp`, which only counts inline 
text lines. Alert text is rendered as markdown — a stack of block-level 
headings, paragraphs and lists — so line-clamp never clamped multi-block 
content, and the `scrollHeight > clientHeight` overflow probe tripped on short 
single-line alerts (inline content like bold/inline-code leaves `scrollHeight` 
a few px above `clientHeight` even when nothing is clipped).
   
   Fix: clamp by height (`max-height` + `overflow: hidden`) and decide overflow 
by comparing `scrollHeight` against that height, so the toggle appears only 
when content is actually hidden — independent of the markdown structure.
   
   Follow-up to #68329.
   
   ##### Collapsed — long alert clamps with a working "See more"; short alert 
shows none
   
   - _screenshot: collapsed_
   
   ##### Expanded — "See more" reveals the full alert and switches to "See less"
   
   - _screenshot: expanded_
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.8)
   
   Generated-by: Claude Code (Opus 4.8) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to