shahar1 commented on code in PR #68916:
URL: https://github.com/apache/airflow/pull/68916#discussion_r3477235347


##########
providers/celery/newsfragments/68916.feature.rst:
##########
@@ -0,0 +1 @@
+Add ``[celery] json_logs`` config option so the Celery worker can emit 
structured JSON logs independently of the global ``[logging] json_logs`` 
setting.

Review Comment:
   We currently don't use newsgraments in providers 



##########
providers/celery/tests/unit/celery/cli/test_celery_command.py:
##########
@@ -386,6 +386,50 @@ def test_worker_starts_when_hostname_is_unique(
         mock_pools_reset.assert_called_once()
 
 
[email protected](not AIRFLOW_V_3_0_PLUS, reason="configure_logging only 
called in Airflow 3+")
[email protected]("mysql", "postgres")

Review Comment:
   Backends should be mocked, why do we need this decorator?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to