hanxdatadog commented on code in PR #68916:
URL: https://github.com/apache/airflow/pull/68916#discussion_r3483770148
##########
providers/celery/newsfragments/68916.feature.rst:
##########
@@ -0,0 +1 @@
+Add ``[celery] json_logs`` config option so the Celery worker can emit
structured JSON logs independently of the global ``[logging] json_logs``
setting.
Review Comment:
Fixed: removed the newsfragment file — providers don't use them.
##########
providers/celery/tests/unit/celery/cli/test_celery_command.py:
##########
@@ -386,6 +386,50 @@ def test_worker_starts_when_hostname_is_unique(
mock_pools_reset.assert_called_once()
[email protected](not AIRFLOW_V_3_0_PLUS, reason="configure_logging only
called in Airflow 3+")
[email protected]("mysql", "postgres")
Review Comment:
Fixed: removed the decorator. The tests only run on Airflow 3+ (the `skipif`
guard), and in that path `worker()` calls `configure_logging` rather than
`settings.validate_session()`, so no real DB backend is needed. `celery_app` is
fully mocked as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
