ferruzzi commented on issue #69065: URL: https://github.com/apache/airflow/issues/69065#issuecomment-4814082359
To start with, I'm absolutely not going to claim any expertise in the token scope domain. Ash caught a bug that I missed and existing unit tests didn't cover so I covered it based on his suggestion. So I have some small experience, but I'm definitely not The Token Scope Guy 😅 . That said, based on what I learned while fixing that, I like the direction this is going and I'd be +1 for moving forward in 3.4.0 with a single PR migration. Updating `test_token_scope_boundaries.py` should be trivial. `_all_route_policies()` currently iterates over `execution_api_router.routes` checking `isinstance(route, APIRoute)`. A shared `iter_materialized_routes()` helper should be a drop-in replacement for the iterator and the test's actual policy assertions in the `NON_DEFAULT_TOKEN_POLICY` dict stay untouched. The build-time factory looks like the right way forward and as long as the proposed new iterator includes all of the token types, it should be a straight substitution on this end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
