potiuk commented on issue #69065: URL: https://github.com/apache/airflow/issues/69065#issuecomment-4815434299
> One extra thing worth considering: FastAPI 0.137.2 added [`iter_route_contexts()`](https://github.com/fastapi/fastapi/releases/tag/0.137.2) for advanced use cases that previously inspected `router.routes`- exactly the category our failing guards fall into. That makes this cheaper than it first looks: rather than a minor-version jump, we'd only bump the lower bound from `>=0.137.1` to `>=0.137.2` and use FastAPI's helper as the shared introspection primitive. The fallback is to keep `>=0.137.1` and add a small local compatibility helper with equivalent behavior, but given the patch-level cost, I'd lean toward the upstream primitive. Oh nice find! I looked only at the 0.137.1 - but indeed, that's then far easier change than it seems - the only thing, I think it needs is to remove our hacks that were added before (the one @ferruzzi spoke about) as they should be not needed any more. Maybe you can attempt to do it in your PR @Revanth14 -> and that should give others a chance to see how it would look like (and it will likely need some serious manual testing of the auth cases that are related to those route manipulations of ours around OTEL/ token scope ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
