Andrushika commented on code in PR #68991:
URL: https://github.com/apache/airflow/pull/68991#discussion_r3485604184
##########
dev/breeze/src/airflow_breeze/utils/packages.py:
##########
@@ -683,6 +683,27 @@ def get_cross_provider_dependent_packages(provider_id:
str) -> list[str]:
return get_provider_dependencies()[provider_id]["cross-providers-deps"]
+def get_cross_provider_dependencies_for_extras(provider_id: str) -> list[str]:
Review Comment:
Thanks for reviewing!
I think the behavior in packages.py:982-984 is a bit different. In addition
to filtering the requirement packages, regenerate_pyproject_toml() also prints
suspend messages and preserves maintainer comments in the dependencies section.
Furthermore, per the comment at packages.py:916-920, this function
intentionally keeps dependencies as text instead of parsing them. I would
suggest not making a change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
