Andrushika opened a new pull request, #68991:
URL: https://github.com/apache/airflow/pull/68991
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
For user-facing UI changes, please attach before/after screenshots (or a
short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
This PR fixes an inconsistency between provider documentation generation and
provider `pyproject.toml` generation.
When generating provider `pyproject.toml` files, cross-provider dependencies
are filtered before being added as optional extras: dependencies that are
already present in required dependencies, or that belong to suspended
providers, are not added as extras.
However, the provider README/index documentation was rendered from the raw
`cross-providers-deps` list. Since `cross-providers-deps` is an import-level
graph, it can include providers that are already required dependencies. This
could cause the docs to show invalid `provider[extra]` installation examples
for extras that do not exist in `pyproject.toml`.
This PR adds `get_cross_provider_dependencies_for_extras()` and uses it when
setting `CROSS_PROVIDERS_DEPENDENCIES` in the provider Jinja context. The
helper applies the same filtering logic used by provider `pyproject.toml`
generation, keeping the generated docs consistent with installable provider
extras.
This is my first contribution to Airflow, so feedback is very welcome.
closes: #63891
Tests:
* `breeze run pytest
dev/breeze/tests/test_packages.py::test_get_cross_provider_dependencies_for_extras`
* `prek --files dev/breeze/src/airflow_breeze/utils/packages.py
dev/breeze/tests/test_packages.py`
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes (please specify the tool below)
<!--
Generated-by: Claude following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
