gingeekrishna commented on PR #69102: URL: https://github.com/apache/airflow/pull/69102#issuecomment-4834281832
Thanks for the detailed review, @MaksYermak! We haven't run the full Dataflow system tests — we only exercised unit tests and the existing beam hook test suite locally. Your point about using the existing `is_dataflow_job_id_exist_callback` to also drive the API poll is a cleaner design than introducing a separate `periodic_callback`, and the note about the fd-blocking concern is well taken. Since you're close to finishing your own fix with the correct approach, we're happy to close this PR and defer to yours. We'd rather avoid parallel work that heads in incompatible directions. Just let us know if there's anything from this PR you'd find useful to carry forward, or if you'd prefer we simply close it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
